This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH resend] allow connecting to xenconsole from remot

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH resend] allow connecting to xenconsole from remote hosts
From: Muli Ben-Yehuda <muli@xxxxxxxxxx>
Date: Thu, 28 Sep 2006 00:14:13 +0300
Cc: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Anthony Liguori <anthony@xxxxxxxxxxxxx>, Orran Y Krieger <okrieg@xxxxxxxxxx>
Delivery-date: Wed, 27 Sep 2006 14:14:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1400046.1B2B%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060926152635.GA22797@xxxxxxxxxxxxxxxxxx> <C1400046.1B2B%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11
On Wed, Sep 27, 2006 at 10:17:42AM +0100, Keir Fraser wrote:
> On 26/9/06 16:26, "Muli Ben-Yehuda" <muli@xxxxxxxxxx> wrote:
> > The attached patch makes xenconsole send and receive console messages
> > over a remote connection, instead of via stdin/stdout - if given the
> > --remote switch. It is useful for proxy'ing real console message or
> > other protocol messages (such as gdb) between dom0 and a remote
> > host. We're currently using it for proxying gdb between gdbstub in a
> > partition that talks gdb over the console page to a remote host
> > running gdb.
> Reconsidering this patch, I think it's okay to put socket connection
> capability into the client. *But*:
>  1. It can't go in until development reopens for 3.0.4.

Sure, that's completely understandable.

>  2. I think the buffering code is not quite there yet. What you want is to
> make all fd's non-blocking, have small (e.g., 1kB) buffers, and then only
> add an fd to the read-set if its buffer is not full,  and only add an fd to
> the write-set if its buffer is not empty. The buffers can stay as ring
> buffers, so a bunch of that code probably stays.

Ok. I think it will end up being more code than what we do right now,
but if you prefer it this way, fine.

>  3. The networking options are confusing. What are the 'remote' and
> 'gateway' options intended for?

--remote = activate the networking.
--gateway = allow connections from any host, not just localhost

suggestions for better names will be appreciated.

> I think that the networking and buffering-fixes parts of the patch should be
> split. We can put in the buffering/select() changes first.

Ok. I'll implement and resubmit in the 3.0.4 timeframe, other things
require my attention for the time being.


Xen-devel mailing list