This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH] Fix gdbserver-xen build errors

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] Fix gdbserver-xen build errors
From: Horms <horms@xxxxxxxxxxxx>
Date: Fri, 1 Sep 2006 10:17:04 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Travis Betak <travis.betak@xxxxxxx>
Delivery-date: Fri, 01 Sep 2006 03:14:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C11CED6C.1E76%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <Pine.LNX.4.62.0608311230220.5417@twinkletoes01> <C11CED6C.1E76%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: mutt-ng/devel-r804 (Debian)
On Thu, Aug 31, 2006 at 07:47:56PM +0100, Keir Fraser wrote:
> On 31/8/06 7:14 pm, "Travis Betak" <travis.betak@xxxxxxx> wrote:
> > I guess it was not the correct fix =)
> > 
> > Yeah, I didn't take into account any predefined CFLAGS or MAKE.  So your
> > patch is much better.
> > 
> > Perhaps a better place to put the define is in the gdbserver-xen sparse
> > directory's Makefile.in.  That will narrow the scope of the define a
> > bit.  How does the following look to you? ...or something similar?
> I just checked in a more general fix, which simply defines the macro in
> xenctrl.h if it isn't defined already.

Excellent, thanks.

  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>