This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] XEN: use C locale in bootup message

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] XEN: use C locale in bootup message
From: Horms <horms@xxxxxxxxxxxx>
Date: Fri, 1 Sep 2006 10:25:52 +0900
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 01 Sep 2006 03:15:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C11D1817.2057%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060831042712.GA24077@xxxxxxxxxxxx> <C11D1817.2057%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: mutt-ng/devel-r804 (Debian)
On Thu, Aug 31, 2006 at 10:49:59PM +0100, Keir Fraser wrote:
> On 31/8/06 5:27 am, "Horms" <horms@xxxxxxxxxxxx> wrote:
> > And in that environment Japanese text was ending up in
> > include/xen/compile.h, and coming out as complete garbage
> > on xen console over serial.
> Was it just date values coming out in Japanese? If so, can we get away with
> just setting LC_TIME=C (not setting LANG or LC_ALL at all)?

Yes, only date seems to be the problem. The fix could be limited to
inside of $(shell date), I think $(shell LC_ALL=C date) would solve
the problem that I am seeing. However setting LC_TIME does not resolve
the problem, as if LC_ALL is set in the environment it seems that
LC_TIME is ignored.

As for LANG, I think that is irrelevant for date. 
I suspect we can get rid of it all together without any ill effects.

The reason that I went with a more general (sledge-hammer) approach as
I'm not sure what other commands may be affected with other locales.
But it is probably safe enough just to set LC_ALL for date. If you would
like me to come up with a more minimal patch that fixes the problem for
Japanese environments at least, and probably all environments, let me
know. Its probably a bit easier for me to test than you.

  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>