WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] X86_64 "assert" when booting 64-bit image.

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] X86_64 "assert" when booting 64-bit image.
From: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Date: Thu, 9 Feb 2006 10:07:35 -0800
Cc: "Petersson, Mats" <Mats.Petersson@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 09 Feb 2006 18:19:34 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcYtoVl0JRuP7o1ZTmidOlAQxxYuoQAAIOGg
Thread-topic: [Xen-devel] X86_64 "assert" when booting 64-bit image.
Keir Fraser wrote:
> On 9 Feb 2006, at 17:44, Nakajima, Jun wrote:
> 
>> I think that particular check is valid; it's basically saying "we
>> shadow page tables only". I feel mfn_is_page_table can be wrong with
>> the type PGT_fl1_shadow, which is bigger than PGT_l4_shadow.  Let me
>> check and come back. I slightly remember I needed to kill the check
>> when I was debugging the code, but not sure if it was triggered by a
>> bug. 
> 
> Yeah, you killed the check by calling ___shadow_status() directly in
> one place, but there's also a path via sync_all which still was bad.
> 
> I just killed the whole function and renamed ___shadow_status() to
> take its place.
> 
>   -- Keir

Sounds sensible. That check was overkill for the non-debug Xen. I
checked if we can remove the whole section, and it worked fine (i.e.
64-bit hvm guest on the 64-bit Xen).

Jun
---
Intel Open Source Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel