[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] automation/eclair: deviate R2.6 for the x86 emulator
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Shuaidong" <Shuaidong.Chen@xxxxxxx>
- Date: Tue, 10 Nov 2026 21:47:27 +0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kuOC0z7hPR0t72EWgKTlQyVtr1z3gRV6UdQk15BflLQ=; b=JCEuZs1FleHb3XBNg7pVDof0LbZYqO1zZCPIjJF5Wn6uRIMo5EyoAkBy7KxSRinpUXTS5aPg9L17dO1aZ3Y2MLk4XLLhda7zL4dPjJ+/CmHx2XlSeIqqgE7rq+tCgVgOKvCEZHD3kIm+jfYsAn7YvR33ZEXTnfb9THGiQwi5uBSjNtXzj8hD0Dl4SYm4NDlIz4ixaN34JaL0dhXF/3XW1TkbNgOf1wX/p390T6rXayIsgQV0fBVhzv/uNgdEfJDCQ/WPgTddlT0jRHB7RsoFRnYdF9fZloZRtjKNIbABB6C4QZ1sPBwICys1ayJ5HbF24s9b3EToh0wesVzkRLqccg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LHKy9Q8SZlv7KNFPy0VnwdJU/HiPRPhK11rCivUk8krDFn4EWL1/L4CSD9ThsFeyVEX/p3Gf9OABOxn9rXCbvyLWOvcPit5Gxtp/FkmhbK3XDlPyWq+Vo66qrW2MdpeRvqkqDbuW2hzBSoCx9N1/WrLLzAwv0FS6UtZ+gDW02dlxU926MDeuoAceDPUqq30nIfDx05eBYppdrhCQ97R9EEVU3zoJwB+I0E/HtsN9z2psX33UvWiCuF19sbEWl0FB/PD9L/u0ObX81VTDqAiOQ39CXLqtvWO580lATcpwFQFpq0kWd2qJvrzM8S15ilncn/pim+IYQ+56BWzMrSJSzA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 10 Nov 2026 13:47:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/10/2026 9:29 PM, Jan Beulich wrote:
On 10.11.2026 14:24, Shuaidong Chen wrote:
--- a/automation/eclair_analysis/ECLAIR/deviations.ecl
+++ b/automation/eclair_analysis/ECLAIR/deviations.ecl
@@ -55,6 +55,11 @@ removed by the compiler, the resulting slowdown is
negligible."
-config=MC3A2.R2.6,reports+={deliberate,
"any_area(text(^.*__maybe_unused.*$))"}
-doc_end
+-doc_begin="With CONFIG_HVM=n the FPU, MMX and SIMD parts of the x86 emulator are compiled out, leaving labels with no goto targeting them, many generated by the CASE_SIMD_* macros.
+Annotating them would only add churn to the emulator, therefore it is deemed better
to leave such files as is."
+-config=MC3A2.R2.6,reports+={deliberate,
"any_area(any_loc(file(^xen/arch/x86/x86_emulate/.*$)))"}
+-doc_end
Both the doc above and the one below specifically mention HVM=n. Yet the
config= doesn't (and can't, aiui) limit things to that case. Imo either
the HVM=n mention wants dropping, or this deviation wants putting in
place only when actually HVM=n.
Jan
Right, I'll drop the HVM=n mention. Limiting the deviation to HVM=n
would need the ECLAIR setup to load config conditionally, which seems
excessive here. With HVM=y the emulator has no unused labels anyway
(-Wno-unused-label is only passed for !HVM), so the wider scope doesn't
hide anything. HVM=n stays in the commit message only as the example.
v3 to follow.
--- a/docs/misra/deviations.rst
+++ b/docs/misra/deviations.rst
@@ -116,6 +116,14 @@ Deviations related to MISRA C:2012 Rules:
such labels poses no risks.
- Tagged as `deliberate` for ECLAIR.
+ * - R2.6
+ - With CONFIG_HVM=n the FPU, MMX and SIMD parts of the x86 emulator are
+ compiled out, leaving labels with no goto targeting them, many of them
+ generated by the CASE_SIMD_* macros. Annotating them would only add
+ churn to the emulator, therefore it is deemed better to leave such
+ files as is.
+ - Tagged as `deliberate` for ECLAIR.
+
* - R3.1
- Comments starting with '/\*' and containing URLs are safe as they are
not instances of commented-out code.
--
Thx and BRs,
Shuaidong Chen
|
