Re: [PATCH v2] automation/eclair: deviate R2.6 for the x86 emulator

[Jan Beulich <jbeulich@xxxxxxxx>]

On 10.11.2026 14:24, Shuaidong Chen wrote:
> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl
> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl
> @@ -55,6 +55,11 @@ removed by the compiler, the resulting slowdown is 
> negligible."
>  -config=MC3A2.R2.6,reports+={deliberate, 
> "any_area(text(^.*__maybe_unused.*$))"}
>  -doc_end
>  
> +-doc_begin="With CONFIG_HVM=n the FPU, MMX and SIMD parts of the x86 
> emulator are compiled out, leaving labels with no goto targeting them, many 
> generated by the CASE_SIMD_* macros.
> +Annotating them would only add churn to the emulator, therefore it is deemed 
> better to leave such files as is."
> +-config=MC3A2.R2.6,reports+={deliberate, 
> "any_area(any_loc(file(^xen/arch/x86/x86_emulate/.*$)))"}
> +-doc_end

Both the doc above and the one below specifically mention HVM=n. Yet the
config= doesn't (and can't, aiui) limit things to that case. Imo either
the HVM=n mention wants dropping, or this deviation wants putting in
place only when actually HVM=n.

Jan

> --- a/docs/misra/deviations.rst
> +++ b/docs/misra/deviations.rst
> @@ -116,6 +116,14 @@ Deviations related to MISRA C:2012 Rules:
>         such labels poses no risks.
>       - Tagged as `deliberate` for ECLAIR.
>  
> +   * - R2.6
> +     - With CONFIG_HVM=n the FPU, MMX and SIMD parts of the x86 emulator are
> +       compiled out, leaving labels with no goto targeting them, many of them
> +       generated by the CASE_SIMD_* macros. Annotating them would only add
> +       churn to the emulator, therefore it is deemed better to leave such
> +       files as is.
> +     - Tagged as `deliberate` for ECLAIR.
> +
>     * - R3.1
>       - Comments starting with '/\*' and containing URLs are safe as they are
>         not instances of commented-out code.