Re: [PATCH 07/17] hvmloader: add basic Q35 support

[Thierry Escande <thierry.escande@xxxxxxxxxx>]

On 5/4/26 16:54, Jan Beulich wrote:
> On 13.03.2026 17:35, Thierry Escande wrote:
>> @@ -209,7 +225,16 @@ void pci_setup(void)
>>      {
>>          do { isa_irq = (isa_irq + 1) & 15;
>>          } while ( !(PCI_ISA_IRQ_MASK & (1U << isa_irq)) );
>> -        pci_writeb(PCI_ISA_DEVFN, 0x60 + link, isa_irq);
>> +
>> +        if ( is_running_on_q35 )
>> +        {
>> +            pci_writeb(PCI_ICH9_LPC_DEVFN, 0x60 + link, isa_irq);
>> +        }
>> +        else
>> +        {
>> +            pci_writeb(PCI_ISA_DEVFN, 0x60 + link, isa_irq);
>> +        }
> 
> Nit: Easier to read imo without the figure braces.

I'll rework that part and use a isa_devfn variable instead.

Regards,


--
Thierry Escande | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech