Re: [PATCH 06/17] hvmloader: Move pci devices setup to a separate function

[Thierry Escande <thierry.escande@xxxxxxxxxx>]

On 5/4/26 16:52, Jan Beulich wrote:
> On 13.03.2026 17:35, Thierry Escande wrote:
>>  void pci_setup(void)
>>  {
>>      uint8_t is_64bar, using_64bar, bar64_relocate = 0;
>>      uint32_t devfn, bar_reg, cmd, bar_data, bar_data_upper;
>>      uint64_t base, bar_sz, bar_sz_upper, mmio_total = 0;
>> -    uint32_t vga_devfn = 256;
>> +    uint8_t vga_devfn = 0xff;
> 
> This change (and the related ones elsewhere) looks bogus to me: 0xff is
> a valid devfn value, whereas 256 isn't.

I'll revert this.

Regards,



--
Thierry Escande | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech