Re: [PATCH v5 5/6] argo: introduce CONFIG_ARGO_DEBUG

[dmukhin@xxxxxxxx]

On Thu, Jun 04, 2026 at 02:52:50PM -0400, Jason Andryuk wrote:
> On 2026-06-04 13:37, Jan Beulich wrote:
> > On 03.06.2026 21:41, dmukhin@xxxxxxxx wrote:
> > > Add Kconfig knob to enable traces for Argo debugging.
> > > 
> > > Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
> > > ---
> > > Changes since v4:
> > > - fixed dependency on a new Kconfig knob on ARGO
> > > 
> > > Changes since v3:
> > > - dropped uneeded "If unsure, say N." from new Kconfig description
> > > ---
> > >   xen/common/Kconfig | 6 ++++++
> > >   xen/common/argo.c  | 3 +--
> > >   2 files changed, 7 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> > > index 5ff71480eebe..7676a78dca71 100644
> > > --- a/xen/common/Kconfig
> > > +++ b/xen/common/Kconfig
> > > @@ -491,6 +491,12 @@ config ARGO
> > >             If unsure, say N.
> > > +config ARGO_DEBUG
> > > + bool "Argo: enable debug traces (UNSUPPORTED)" if ARGO
> > 
> > Why is the "if ARGO" still there? That's fully redundant with ...
> > 
> > > + depends on ARGO
> > 
> > ... this. I said the v4 issue could be fixed while committing. Now you've
> > posted another version (adding to overall mail volume) and an adjustment
> > still needs doing.
> 
> With the if ARGO removed:
> 
> Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Thank you!