[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 5/6] argo: introduce CONFIG_ARGO_DEBUG


  • To: Jan Beulich <jbeulich@xxxxxxxx>, <dmukhin@xxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Thu, 4 Jun 2026 14:52:50 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fGRd8gJV6vuRs7Y4iZ6npCIBh3/9cndPA+A/QSp/A0M=; b=fDMESzXEDyV6mvPyaRgKpqzeUyxUWw48yZYuti+nQmuLse6Ea6GDJAGizlV7YJKLHoAxjaHbVbc+2pSSXQmDFsYoXFyG+nz07v5PaLPvyBosTgHe8Uk3PL3ea0Fpywx08O6SUTaPvbouAsCRYlVWU63mq2ud9W6RyCLVu7uDFGoHFCSb89Ir4tMdhJlY/+a6L/hq/3ujG3I3Y6c6bOdi1k5vkzRyP56dQEgbX4inxHWb31aG+OA4/GbtL0QlXMr3kOy6NlzSt6WChg3OSrTqaRMEyiB0xUwPddKJD7R5jAEToWXoIhlBLCrBiFlZMeVgY/mfn9y9Xj+rsHBmT5I22Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wmYcFrWqNhwwr3qmsv/gqkFuGxdDzseRCWwugsZaxXJLzq+1njMZl5Ss41RTFUL7KrHbnX/XUxZjz2bbI01rOdUf8NkmVDKmuzkO589fX8kom5umGXXr0WRkC7PjZtBhl49O+eLOG+CPIGqqtDbSF3OqkZhPFUxV7eQLaqyuKbJi3ST4WbobQHq3ijcRIhZeqcpaaEnFzbeBe/yCDuCNAoOa9/972lf/J64WxrlRS2vEWy9mbW98rtdnS1Q2LuTZXRYlqpJD2IZPTae7/9wH6aDW5hUSGNQCYeu0XvqQseCA/0qrJsypuQHfo0SQpwtUYbhA79uS7HrUnbvGh0yd4w==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: <andrew.cooper3@xxxxxxxxxx>, <anthony.perard@xxxxxxxxxx>, <julien@xxxxxxx>, <michal.orzel@xxxxxxx>, <roger.pau@xxxxxxxxxx>, <sstabellini@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 04 Jun 2026 18:53:06 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2026-06-04 13:37, Jan Beulich wrote:
On 03.06.2026 21:41, dmukhin@xxxxxxxx wrote:
Add Kconfig knob to enable traces for Argo debugging.

Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
---
Changes since v4:
- fixed dependency on a new Kconfig knob on ARGO

Changes since v3:
- dropped uneeded "If unsure, say N." from new Kconfig description
---
  xen/common/Kconfig | 6 ++++++
  xen/common/argo.c  | 3 +--
  2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index 5ff71480eebe..7676a78dca71 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -491,6 +491,12 @@ config ARGO
If unsure, say N. +config ARGO_DEBUG
+       bool "Argo: enable debug traces (UNSUPPORTED)" if ARGO

Why is the "if ARGO" still there? That's fully redundant with ...

+       depends on ARGO

... this. I said the v4 issue could be fixed while committing. Now you've
posted another version (adding to overall mail volume) and an adjustment
still needs doing.

With the if ARGO removed:

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

-Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.