[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen/common: llc-coloring: clear color count on parse failure
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Mon, 18 May 2026 11:11:25 +0300
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=iOSMKDA3THo11cMixsiTenFnNLnwDVr7W+zNctBt4B4=; fh=0sVRqm7+oyz7WJ/bTvyRrhIQoOB1v0nJ1T68JVaBfuo=; b=LMlKZax5XUtQr5Y9PftuJ2CojZLCMMXiLZiH7w6D0dX+i6DLubku3XC1+6SmdI2ojp hgIi7VCVAvnoA8E3HHaqIak7WENbaqDmSeaUBYVOb7QBytmc8tTSwGDmmsnYjNeTuKls bfFbn4RfEerhmqup8WDkSlq1Es7JglI6sXWr4UGZnOFTT+FeCiTRwlE+RlwSrdl2eUp6 R/UWzQCxZRV7Azm2f2kcHOUjFSY17pzg/wB9xuwjGrI/E/QLwmdnR69ZY4BQf9jzM6fJ MeCqR8WmImB7bogr/Mg/qUJZN/G2A+1v9gcxkJBsXFXz/xVFZUBDQJdkkP0uTmnwaZV+ 2D8w==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1779091897; cv=none; d=google.com; s=arc-20240605; b=jzud0CBxv77pSuJlwW2ZX455dMZv9bJhV5u/Mq2TsIE1J2Ls5UyoKsFpSpP4IYTMAw ZGLJDE9V7ixXhBmJUF4bDxXXbYZtex7mhUGkxbZE3kGinu73Jn5c8Nie+2/bOu84/eZR N5GnxTGUon8U8qJf4/9w7qDppp85I0nycSGuLQ0aKgf2+WdErRz54d882Bno2BpVsrLi NRWPyA25kReRcXatWn48wHxXrG9qUYWAekNelQg2C9R/Y2fUnLRjFiDfdwlWnyanOpDh tF3hqAqVqPROzCGObSlAUmtECU9MYKBKrj4tUhN9CgMprUMv0roEfdGu5LD4pUyHZ5I5 5UHw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Mykola Kvach <mykola_kvach@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Mon, 18 May 2026 08:11:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Michal,
Thank you for the review.
On Mon, May 18, 2026 at 8:42 AM Orzel, Michal <michal.orzel@xxxxxxx> wrote:
>
>
>
> On 16-May-26 17:03, Mykola Kvach wrote:
> > From: Mykola Kvach <mykola_kvach@xxxxxxxx>
> >
> > parse_color_config() updates the caller-provided color count while
> > parsing. If parsing later fails, leave the count at zero so callers
> > do not consume a partially parsed configuration.
> I would also add for clarity:
> The bug is reachable in practice: cmdline_parse() ignores the -EINVAL
> from a custom_param callback, so boot continues with the partial
> xen_num_colors / dom0_num_colors that llc_coloring_init() and
> dom0_set_llc_colors() then consume.
Ack, I will add this to the commit message in the next version.
>
> >
> > Fixes: 6cdea3444eaf ("xen/arm: add Dom0 cache coloring support")
> > Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Best regards,
Mykola
|
