[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen/common: llc-coloring: clear color count on parse failure
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 18 May 2026 07:42:20 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O8KRYEoASOjstQf7k4/jjLmY7pzeWH549moAVDbBBdU=; b=fvMGLSqV8SIXuTORXw8JB+o01/g8+LtFSYfO9HN6S1SMpKGtuQHVF2hjitOxM6+jzngErJHuy191g/7J16bkltmBudfVx/PMt+McCHYecxUKIedcIO36R+oKweo6v+m3gPy9gzGHNQHOIoSX8OustZuy6Inywu9iJn7UY+Lo9M1GUwd20FT7vmNr0DC6gFCa5W8dab3YdKl+eFc6VDZIKjcEvcO3mYMOxowHsVC4LheqfT7z1vABJXAxZfNRUd21vxWsH3XZ8wQ/bC1bB5ZGD6JjtAnEWGjRDszDCSozHRKMj/o24NWIuidqD+wExe0ZHZC1BPXmH6jAabdD8hkSkw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SQNEAlT9ronIAHSwuC5bzcksG5to1H+Oz+VHH72HLuFGUy6Ba/IXh6aFMtLOsi8do4sIGtntXwrMqxLN1qtuLeO/ZX81KvnUtYW1QQmieN97uT5vH9/Zx00UaStlw9fL+G0FuhVjiahogd74k0ItOxjBeJwwLE6Wtj6Yp7omEMlOBRHD3ajkJcavud2ZUk8e+bI/W2xMbmQ18oV+Rd6+IZiNgDjecOwCn8Ab8TSbr2k83OuDYx9bFgEmHp9tGMceJ2JrdRoo3YEVfR43hSL79AhP9ilYxiylByReh3pFEINag3x/TpAE1IDeGv/TJEiC/I1Q1u31PW9fuQlICdkMFw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Mykola Kvach <mykola_kvach@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Mon, 18 May 2026 05:42:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16-May-26 17:03, Mykola Kvach wrote:
> From: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> parse_color_config() updates the caller-provided color count while
> parsing. If parsing later fails, leave the count at zero so callers
> do not consume a partially parsed configuration.
I would also add for clarity:
The bug is reachable in practice: cmdline_parse() ignores the -EINVAL
from a custom_param callback, so boot continues with the partial
xen_num_colors / dom0_num_colors that llc_coloring_init() and
dom0_set_llc_colors() then consume.
>
> Fixes: 6cdea3444eaf ("xen/arm: add Dom0 cache coloring support")
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
