Re: [XEN][PATCH v8] x86: make Viridian support optional

[Jason Andryuk <jason.andryuk@xxxxxxx>]

On 2025-11-20 05:42, Grygorii Strashko wrote:
> Hi Jan,
>
> On 20.11.25 10:50, Jan Beulich wrote:
> > (adding v8 tag to subject)
> >
> > On 19.11.2025 20:32, Grygorii Strashko wrote:
> > > From: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
> > >
> > > Add config option VIRIDIAN that covers viridian code within HVM.
> > > Calls to viridian functions guarded by is_viridian_domain() and 
> > > related macros.
> > > Having this option may be beneficial by reducing code footprint for 
> > > systems
> > > that are not using Hyper-V.
> > >
> > > [grygorii_strashko@xxxxxxxx: fixed NULL pointer deref in
> > > viridian_save_domain_ctxt(); stub viridian_vcpu/domain_init/deinit()]
> > > Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
> > > Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
> > > Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
> > As before - this R-b likely would need dropping, ...
> >
> > > ---
> > > changes in v8:
> > > - drop checks from viridian_load_vcpu/domain_ctxt()
> > > - drop check "value != 0" in HVM_PARAM_VIRIDIAN handler, laways return
> > >    -ENODEV for VIRIDIAN=n
> > ... when more than just cosmetic changes are made. Jason, please can you
> > indicate whether it's fine to retain?
Yes.

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Thanks,
Jason