[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: correct scrub_page_{hot,cold}() prototypes
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Wed, 23 Jul 2025 16:47:11 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1753282031; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=HVCDQEWGqF8la3C3xBM1trIpYtBVkznL9Tczio+hfiI=; b=5unZWav+Z4n7fy3f+sDierpKm3ASA70J7QCEwyvKAlDAueUc2nr6DyjLaZNjB6GcTdPO kGtWh+2UzpAtcqDnoE5eio7F5k73l1oAIfeII0HTEPR/72ie0I/lJv80gMoEKDdVzZgbB 7Zmnfpys7OfBE/jeNjleYP3tqIFTonmhH3cXavSZRUWEPzp8OVVoj8Pr86nbaRTc5jVdI gDs8l5e505hO85gNPZ0nBeEQFroa8pdzuGx+bbccnzh07fZCJ9+1HPHBF6N9IKhNlyKsb 7Yer1FAgUNVl+9nKPHdntIUjNZwjHOO1snku+ZiiJTd2XhIVBpVAcG2HIWH62dO7Lil65 x9EGazGd2/UGDohYDgETgvQ0W3bRqTHXvqDKpf8FhTTOS8/WU9VCtxT4Xhf/llKl0OHyJ WN6Qvtk3ThFOD3FFOEpQ6g5D+5iDvbrFy6BKuPLWesIFTB0XNnANBd90DK6HmbB5zjPt6 7Vms+0GxfRbhnngJKq7OoDqeTzWrlRIk6oWrMux1mxzzPLznHfjHKN/xm0oUy49f9vBt/ VRDUIW2IZKrsIrX2PMscR/k0tWALqGGLpg65kiDFvPyD8pLvgdb70Z6446merUgQM4YOL GfGn+w6pt0uY7Mq3yjHBDn8dG8M7jlihFjjVID65Q5QSgL4Z5hx5RxRxHKnpd+Q=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1753282031; b=AfoLF7BervQQF4PKYClX4CUiCobStSCzAGVsEL+7smpSWKZDDJv1zpKNjbZGyiphInHi HylISGlk8vYS6BGmcB8OEKSVWLCW8K4KyccGywbvhdctIRCtocyd90mb+hyn+armCYgmg GdIcvrtfq60O9X5CwC2A8c0Q2Bd+RcySx2HCy/sivIqy+3nveq6t4/96Lb1YnAdaF3oFe 1UquGbrgPrq4ubOZ2L6i4tKLu5FNwqWvMQ1WUG45/hV2husMko3hQ/zJFMyiobmrlvO71 7Pi824Vb6CUV+IaQHnln5ncVrlVB1GsJOYAElOYQX78hokYFUNl2+AAp2XcsBKekIsKzv TiP1YQa9yLvNWYD1agJHxZMqEnLTkzREuJZyI+LbBHdilTED7kIWL7Uc8JAUx/XKdPfvE iPR0AVJQI4Dt2PU89UVePtZ350lbGnB5XbWGOg5APKgLKclBxe0XIYi6pjl6p4BchSE9L yrBYOkuLUBj172/FpI/gaunPusfMJb6uFKyfhaHjZG/gJlk887QUtI2ZoeVOtfVbpjtY6 Q0nFb5OsvOthyn3f0Kz2wVelnvQU1SDaeY9RgsCJ0X5V+klzL1AXMPJckHJm8HpIe6wGe FJXUadck9LUDTlByRpDyxh8Z7b1FXblxsdZRLIhP/B2VxVBaHIWwzjZAj6VxOqk=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 23 Jul 2025 14:47:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-07-23 16:37, Jan Beulich wrote:
... to be in line with Misra rule 8.2 requirements.
Fixes: 6ff0cfbfd4f7 ("mm: allow page scrubbing routine(s) to be arch
controlled")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
The offending patch had been pending for far longer than we care about
Misra, and hence at the time of writing I didn't pay attention. And
then
I never looked again. I'm sorry.
Ah, sorry, I didn't notice your patch, I just sent basically an
identical one, feel free to disregard it.
--- a/xen/arch/x86/include/asm/page.h
+++ b/xen/arch/x86/include/asm/page.h
@@ -227,8 +227,8 @@ void copy_page_sse2(void *to, const void
#define copy_page(_t, _f) copy_page_sse2(_t, _f)
#ifdef CONFIG_DEBUG
-void scrub_page_hot(void *);
-void scrub_page_cold(void *);
+void scrub_page_hot(void *ptr);
+void scrub_page_cold(void *ptr);
#endif
/* Convert between Xen-heap virtual addresses and machine addresses.
*/
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
