[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[XEN PATCH] x86/page: fix regressions of MISRA C Rule 8.2


  • To: xen-deve@xxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
  • Date: Wed, 23 Jul 2025 16:45:13 +0200
  • Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=79.60.221.62
  • Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1753281917; h=DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Transfer-Encoding; bh=Hj9SkBRM6qxGwniV9yn1/QKHd/6MxHEHdXZkVFwn50c=; b=Nzhv7/P4bPt9eOfBw/LxdGknG9qNMcJeMxxBLKCTSAyDbHdZL6b9mdgYpA9GOFp7beiD 5HlHAp7HPxWxzNtFV6L3xQuBAvwNknI3TVrJUlauYmj1534pB6tyxvilTbGb6qC7CcCr0 i+/4M1dxSi0fF80GMkD6rk3z+oA4m7lqPW5IKhrrUIbLYWEWmHSxqe4lSWIkc1nNHfqAP U/8MoAaX0MzeVr8BSqu2jL0sbYNwD7vMZKtM2sdR0vYkvUIVxtUQujKbfRYqP9zEuAyLh aG3uKYtWbwEaBO1MufMkzz9Qh5GbErfpkgCmRd0+37LUmxTfwztfpO5bP5ZGCqmP3Z1vP JVmxOduQy/cJKXyHdneySvANaKcLYRZmU8VmK5GSNinKo9OyPpluWxQLzSmydKa1al3Hg 9qYk14/sY4BC0x1Us+MZtHfU03MLfpIhYKLmh9fIBNYE4hrrVHpE0FNpmkhWWDd3I4uWt 5Obp6eFEMKhOilms4rurPxT2usCuFZGjgPo57PwkDvlJplIqkb3w6D6KzSwyu0VTrAwyr jUMgipO7cGzX75YdsqRYW/K04QO4hah7WfizSdbzTlL2D7xVxfOQWX2EteObp8R150sUg zLZQPp7Wru1tNIt9uwGdq5wFijQ8zS9jsFfUkHUYTrdnrd5OT3/XcjAHMKHIJSQ=
  • Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1753281917; b=HNy/XOWSu3g0RxS27xomgJ8S0s6gYtnS5hsl9ugpamOywLE0VAuz1VX77zAzl/0gKVqN aFoIEDttDiKj9twekgaOKEWw5ZRon7rmSUZhTawbCXJtcEujnshcbLNELImdtYKd5B1QD eAZn+M32RrMzohnzfEq1tG3yX32Su2FXq0Ouco13T3l7D9Al+zeXf7AFf8THSDo7FiFGE FGmUBQLKj1ZpSuPsCSXFrVLBLIJHludccHxn01jA7Xw75Qf9JxSJmUREes/uRredKRYO1 /AY+77hkq7iKmxusmvRyzCyJt4WUx/AncFCsVubzU7dwUXJcigM8PDDMnhLnsv7DrU+XL nQ6thAalLrzHGJPXz+pQpzZdy2/tOwisl2UHJaDhyGZf84Z8b6+Vmxf54DD4oNeIaW1Xw 42PfscWvIPzwrmCpbYu+4ArFgmSUXu//CLUbvHW1yVwWfCnZ/n5gCuuoD+VYVqrEoDZiq UIsMxxx1pNmYiUR5OXDBTWF6Lm89mrANAPTBFzqzEw5wvNAgdzm5zdx81ENs0KCD2w6n8 hkNGZs6DvvwT8c4x5+xgNRH62gqAmu+LfttxJe5U3xncjnMe4vkC0YPoCnkcGgLU9qDl2 AP1IZncyY9WmbAF5cGk7IrnHh+gMG6Gg2w9CB7dMsiitlP4awwHahrgWvRN+hNU=
  • Authentication-results: bugseng.com; arc=none smtp.remote-ip=79.60.221.62
  • Cc: consulting@xxxxxxxxxxx, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 23 Jul 2025 14:45:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

The rule states: "Function types shall be in prototype form
with named parameters". Add missing parameter names.

Fixes: 6ff0cfbfd4f7 ("mm: allow page scrubbing routine(s) to be arch 
controlled")
Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
 xen/arch/x86/include/asm/page.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/include/asm/page.h b/xen/arch/x86/include/asm/page.h
index d8e23e614c88..b53cd19f31a4 100644
--- a/xen/arch/x86/include/asm/page.h
+++ b/xen/arch/x86/include/asm/page.h
@@ -227,8 +227,8 @@ void copy_page_sse2(void *to, const void *from);
 #define copy_page(_t, _f)   copy_page_sse2(_t, _f)
 
 #ifdef CONFIG_DEBUG
-void scrub_page_hot(void *);
-void scrub_page_cold(void *);
+void scrub_page_hot(void *pg);
+void scrub_page_cold(void *pg);
 #endif
 
 /* Convert between Xen-heap virtual addresses and machine addresses. */
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.