Re: [Xen-devel] Vmxassist build failure on gcc 3.3.5

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 19/10/06 8:06 pm, "Woller, Thomas" <thomas.woller@xxxxxxx> wrote:

>> I expect placing $DATA_SELECTOR in brackets $(DATA_SELECTOR)
>> will work. I expect the version of cpp is not able to pick
>> out a macro usage when it runs into adjacent punctuation.
>> 
> Yes. () works. Here is patch..
> Thanks for the help
> Tom
> 
> Signed-off-by: Tom Woller <thomas.woller@xxxxxxx>

Oh, the penny drops. It's because we now have -std=gnu99. I deliberately
strip that out of CFLAGS when building asm files in Xen itself, as it makes
gcc really unhappy (doesn't like #-prefixed end-of-line comments). Clearly
it's not partial to $-prefixed macro names either, with older gcc versions.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel