[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Vmxassist build failure on gcc 3.3.5

  • To: "Woller, Thomas" <thomas.woller@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Thu, 19 Oct 2006 21:58:03 +0100
  • Delivery-date: Thu, 19 Oct 2006 14:09:25 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcbznSeBTn7r3870TrOkcPhwGhDWtgAEdkCBAACOytAABAI1Jg==
  • Thread-topic: [Xen-devel] Vmxassist build failure on gcc 3.3.5

On 19/10/06 8:06 pm, "Woller, Thomas" <thomas.woller@xxxxxxx> wrote:

>> I expect placing $DATA_SELECTOR in brackets $(DATA_SELECTOR)
>> will work. I expect the version of cpp is not able to pick
>> out a macro usage when it runs into adjacent punctuation.
> Yes. () works. Here is patch..
> Thanks for the help
> Tom
> Signed-off-by: Tom Woller <thomas.woller@xxxxxxx>

Oh, the penny drops. It's because we now have -std=gnu99. I deliberately
strip that out of CFLAGS when building asm files in Xen itself, as it makes
gcc really unhappy (doesn't like #-prefixed end-of-line comments). Clearly
it's not partial to $-prefixed macro names either, with older gcc versions.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.