[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] Vmxassist build failure on gcc 3.3.5


  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: "Woller, Thomas" <thomas.woller@xxxxxxx>
  • Date: Thu, 19 Oct 2006 14:06:08 -0500
  • Delivery-date: Thu, 19 Oct 2006 12:34:39 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcbznSeBTn7r3870TrOkcPhwGhDWtgAEdkCBAACOytA=
  • Thread-topic: [Xen-devel] Vmxassist build failure on gcc 3.3.5

> I expect placing $DATA_SELECTOR in brackets $(DATA_SELECTOR) 
> will work. I expect the version of cpp is not able to pick 
> out a macro usage when it runs into adjacent punctuation.
> 
Yes. () works. Here is patch..
Thanks for the help
Tom

Signed-off-by: Tom Woller <thomas.woller@xxxxxxx>

diff -r 20522afb2615 tools/firmware/vmxassist/trap.S
--- a/tools/firmware/vmxassist/trap.S   Wed Oct 18 18:23:32 2006
+++ b/tools/firmware/vmxassist/trap.S   Thu Oct 19 13:50:53 2006
@@ -106,7 +106,7 @@
        pushl   %es
        pushal
 
-       movl    $DATA_SELECTOR, %eax    /* make sure these are sane */
+       movl    $(DATA_SELECTOR), %eax  /* make sure these are sane */
        movl    %eax, %ds
        movl    %eax, %es
        movl    %eax, %fs





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.