[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH/RFC] Wrong account for cpus other than 0 on hotplug

  • To: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Fri, 13 Oct 2006 21:33:53 +0100
  • Delivery-date: Fri, 13 Oct 2006 13:45:04 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcbvBuW/JHn5Jlr6Eduu5gANk04WTA==
  • Thread-topic: [Xen-devel] [PATCH/RFC] Wrong account for cpus other than 0 on hotplug

On 13/10/06 6:50 pm, "Glauber de Oliveira Costa" <gcosta@xxxxxxxxxx> wrote:

> Is a x86_64 system with multiple CPUs, process accounting is done wrong after
> one cpu goes off and on again (i.e.: a CPU bounded process is running
> but gets 0% cpu for a time, until situation becomes normal again).
> The following patch is a first attempt to fix it. The struct keeps
> zeroed after HYPERVISOR_vcpu_op() is called, thus leading to wrong
> results. Accounting seems to be done right without it. However, I'm not
> 100 % sure we can just poke it out. Comments on this are very welcome.

This patch turns off the missing ticks accounting entirely, as the
runstate_info structure will never be updated. Are you sure this appears to
be an x86_64-specific issue?

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.