This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-tools] b0893b876c8c4c4eb507d48fc1c4af4268ddecde and watch behaviour

To: Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>
Subject: [Xen-tools] b0893b876c8c4c4eb507d48fc1c4af4268ddecde and watch behaviour
From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Date: Thu, 22 Sep 2005 16:35:55 +1000
Cc: Xen Tools <xen-tools@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 22 Sep 2005 06:34:40 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-tools-request@lists.xensource.com?subject=help>
List-id: Xen control tools developers <xen-tools.lists.xensource.com>
List-post: <mailto:xen-tools@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-tools>, <mailto:xen-tools-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-tools>, <mailto:xen-tools-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-tools-bounces@xxxxxxxxxxxxxxxxxxx
Hi Christian!

        I was looking through b0893b876c8c4c4eb507d48fc1c4af4268ddecde, and it
took me a while to figure out what the code was doing.  I think there
are two issues here:

1) Directories implicitly created by mkdir/write don't fire watches (eg.
mkdir /a/sub/dir only fires a watch event for /a/sub/dir, even if it
also created /a/sub), and
2) Rm only fires a single event for a watch, as an optimization.

The first one is a bug, I think, and I'm testing a patch as I type this.
Fixing the second would actually simplify the xenstored code, but will
mean flooding xenbus_probe with events, so I think we would also want to
introduce a "max_depth" arg to xs_watch.

What do you think?  I can prepare a patch to see how it looks, but my
gut feel is that it'll be a net simplification (xenbus_probe.c and

A bad analogy is like a leaky screwdriver -- Richard Braakman

Xen-tools mailing list

<Prev in Thread] Current Thread [Next in Thread>