Re: [Xen-devel] [rfc] [patch] more 'long' in the hypervisor interface

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Wed, 2006-06-28 at 14:09 -0700, Chris Wright wrote:
> * Hollis Blanchard (hollisb@xxxxxxxxxx) wrote:
> > Hi Keir, we've come across some more users of 'long' in the hypervisor
> > interface: xen/include/public/memory.h. Unlike the dom0_ops, we can't
> > just change these to be 64 bits because 32-bit kernels use these
> > structures for the balloon driver.
> > 
> > I would like to create a new type, say "legacy_ulong_t", to cover these
> > cases and future instances we'll undoubtedly come across. What do you
> > think?
> > 
> > Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx>
> > 
> > diff -r 10db0f8c710d xen/include/public/arch-x86_64.h
> > --- a/xen/include/public/arch-x86_64.h      Wed Jun 28 15:37:45 2006 -0400
> > +++ b/xen/include/public/arch-x86_64.h      Wed Jun 28 16:02:21 2006 -0500
> > @@ -104,6 +104,8 @@ DEFINE_XEN_GUEST_HANDLE(xen_pfn_t);
> >  #define MAX_VIRT_CPUS 32
> >  
> >  #ifndef __ASSEMBLY__
> > +
> > +typedef unsigned long legacy_ulong_t;
> 
> What is legacy about it, this looks quite odd, and I don't think will
> build on i386.

Hopefully my other reply cleared things up for you...

It builds fine for me; what problems do you envision?

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel