WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] [xenppc-unstable] [ppc] some OF implementations do not take

To: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [XenPPC] [xenppc-unstable] [ppc] some OF implementations do not take kindly to closing console ihandles.
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Thu, 08 Jun 2006 17:30:50 -0500
Delivery-date: Thu, 08 Jun 2006 15:30:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1FoShx-0002Yx-Dv@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <E1FoShx-0002Yx-Dv@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2006-06-08 at 22:10 +0000, Xen patchbot-xenppc-unstable wrote:
> # HG changeset patch
> # User Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
> # Node ID 44317a8990db4e2cd17d88d0bcba9f67f8cd2d68
> # Parent  1bb8eff867204b362e5e4aa018432959b4f64930
> [ppc] some OF implementations do not take kindly to closing console ihandles.
> 
> Signed-off-by: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
> ---
>  xen/arch/ppc/boot_of.c |   10 ----------
>  1 files changed, 10 deletions(-)
> 
> diff -r 1bb8eff86720 -r 44317a8990db xen/arch/ppc/boot_of.c
> --- a/xen/arch/ppc/boot_of.c  Thu Jun 08 17:20:11 2006 -0400
> +++ b/xen/arch/ppc/boot_of.c  Thu Jun 08 17:42:26 2006 -0400
> @@ -967,7 +967,6 @@ multiboot_info_t __init *boot_of_init(
>          ulong r3, ulong r4, ulong vec, ulong r6, ulong r7, ulong orig_msr)
>  {
>      static multiboot_info_t mbi;
> -    int of_in;
>  
>      of_vec = vec;
>      of_msr = orig_msr;
> @@ -1001,15 +1000,6 @@ multiboot_info_t __init *boot_of_init(
>      boot_of_rtas();
>  
>      /* end of OF */
> -    of_printf("closing OF stdout...\n");
> -    of_call("close", 1, 0, &of_out);
> -
> -    of_getprop(bof_chosen, "stdin", &of_in, sizeof (of_in));
> -
> -    if (of_in != of_out) {
> -        of_call("close", 1, 0, &of_in);
> -    }
> -
>      of_call("quiesce", 0, 0, NULL);
>  
>      return &mbi;

Not closing stdin/stdout has caused real bugs with Linux on pSeries.
After much hair loss, it was discovered that a USB controller was DMAing
over kernel memory in very very early boot, which doesn't sound like a
problem I'd like to debug, so I don't like this patch.

Can we create a platform blacklist for this logic?

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel