[Xen-devel] Re: [patch] ACM ops interface

[Reiner Sailer <sailer@xxxxxxxxxx>]

Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote
on 06/08/2006 02:42:10 PM:

> 
> On 8 Jun 2006, at 19:32, Hollis Blanchard wrote:
> 
> >>> First, it isn't using XEN_GUEST_HANDLEs where it should
(i.e. when
> >> using
> >>> pointers in the interface). What's a little scary is
that because
> >> it's
> >>> using void* everywhere, we didn't get any compiler warnings
(if
> >> you're
> >>> passing buffers, maybe 'unsigned char *' would be a better
type?).
> >>
> >> Keir responded to this point already
> >
> > I didn't see that, actually.
> 
> Yeah, I don't think I did.
> 
> Anyway, should I take Hollis's patch or do you want it worked on some
> more?
> 
> As for copy_to/from_user sleeping, they don't sleep in Xen but it
would 
> be nice to avoid putting it in a locked region anyway in case we want
> to do anything clever in future. I may start asserting that in debug
> builds.
> 
>   -- Keir
> 

Makes sense.

If Hollis doesn't include it in his patch, then I
will address it next week.

Reiner
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel