WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [Xen-devel] [patch] ACM ops interface

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [patch] ACM ops interface
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Thu, 08 Jun 2006 12:59:55 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Reiner Sailer <sailer@xxxxxxxxxx>, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 08 Jun 2006 10:59:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <9e8e21c1e739faf23d6c4f4c3b16cd39@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <1149778877.13780.5.camel@xxxxxxxxxxxxxxxxxxxxx> <9e8e21c1e739faf23d6c4f4c3b16cd39@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2006-06-08 at 17:11 +0100, Keir Fraser wrote:
> On 8 Jun 2006, at 16:01, Hollis Blanchard wrote:
> 
> > If the ACM ops were always passed in a union, we could replace the 
> > first
> > switch with a single copy_from_user(), and also guarantee that
> > "interface_version" is always in the right place (it's only there
> > coincidentally now). What do you think?
> 
> The interface was deliberately changed away from that style for 
> consistency with other hypercalls. Also to allow larger argument 
> structures to be added to the interface later without breaking backward 
> compatibility (inflating the size of the union).

Ah, that makes sense. Too bad it will uglify the already unpleasant
handle hacks PPC needs to do.

Are you planning to do something similar for the dom0_op structure?

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel