WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-merge

[Xen-merge] Re: [patch] SMP alternatives for i386

To: Gerd Knorr <kraxel@xxxxxxx>
Subject: [Xen-merge] Re: [patch] SMP alternatives for i386
From: Zwane Mwaikambo <zwane@xxxxxxxxxxxxxxxx>
Date: Wed, 14 Dec 2005 11:35:46 -0800 (PST)
Cc: linux kernel mailing list <linux-kernel@xxxxxxxxxxxxxxx>, Xen merge mainline list <xen-merge@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 14 Dec 2005 19:43:17 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <439EE742.5040909@xxxxxxx>
List-help: <mailto:xen-merge-request@lists.xensource.com?subject=help>
List-id: xen-merge <xen-merge.lists.xensource.com>
List-post: <mailto:xen-merge@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=unsubscribe>
References: <439EE742.5040909@xxxxxxx>
Sender: xen-merge-bounces@xxxxxxxxxxxxxxxxxxx
diff -urN -x 'build-*' -x '*~' -x Make -x scripts 
linux-2.6.15-rc5/arch/i386/kernel/smpboot.c 
work-2.6.15-rc5/arch/i386/kernel/smpboot.c
--- linux-2.6.15-rc5/arch/i386/kernel/smpboot.c 2005-12-06 17:00:36.000000000 
+0100
+++ work-2.6.15-rc5/arch/i386/kernel/smpboot.c  2005-12-06 17:06:48.000000000 
+0100
@@ -1351,6 +1352,9 @@
        fixup_irqs(map);
        /* It's now safe to remove this processor from the online map */
        cpu_clear(cpu, cpu_online_map);
+
+       if (1 == num_online_cpus())
+               alternatives_smp_switch(0);
        return 0;
 }

Is that really safe there? Ideally you want to do the switch when the 
processor going offline is no longer executing kernel code.


_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge