|
|
|
|
|
|
|
|
|
|
xen-merge
Re: [Xen-merge] [patch] SMP alternatives for i386
Overall technically, I like this patch. Philosophically, I agree with
it as well - but might I strongly suggest that you avoid the .section
.previous directives and use the nestable .pushsection, .popsection
instead? We are almost to the complexity point with fault handling and
alternatives that we will need nested section overrides.
Fortunaly we don't need that at the moment. And in case we'll really
need it some day it will not be *that* easy. The pointers in the fixup
section will point to the wrong location because we run the UP code not
in-place but copy it to another address ...
cheers,
Gerd
_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge
|
|
|
|
|