|
xen-ia64-devel
[Xen-ia64-devel] RE: [PATCH 06/27] ia64/xen: define NET_SKB_NET to 18 if
Hi, Tony
>> Resolve it by increasing NET_SKB_NET from the default value 16 to 18.
>
>Typo? You mean NET_SKB_PAD here?
>
I think so. :-)
>But in include/linux/skbuff.h it says: "It must be a power of 2".
>
>Explain why 18 is ok.
It's supposed to add NET_IP_ALIGN when network driver allocs
skb with netdev_alloc_skb(). For example, e1000 do like the below, too.
struct sk_buff *new_skb = netdev_alloc_skb(netdev, length + NET_IP_ALIGN);
In the case of xen, xen-frontend.c also uses __netdev_alloc_skb(),
so we need to add 16 + NET_IP_ALIGN for padding.
I think we use NET_SKB_PAD=16+NET_IP_ALIGN or
we add it to length of __netdev_alloc_skb().
The below is my patch being relative to this.
http://xenbits.xensource.com/xen-unstable.hg?cs=797430d25f1b
Best Regards,
Akio Takebe
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-ia64-devel] [PATCH 01/27] ia64: move function declaration, ia64_cpu_local_tick() from .c to .h, (continued)
- [Xen-ia64-devel] [PATCH 01/27] ia64: move function declaration, ia64_cpu_local_tick() from .c to .h, Isaku Yamahata
- [Xen-ia64-devel] [PATCH 04/27] ia64/xen: introduce definitions necessary for ia64/xen hypercalls., Isaku Yamahata
- [Xen-ia64-devel] [PATCH 02/27] ia64/xen: introduce synch bitops which is necessary for ia64/xen support., Isaku Yamahata
- [Xen-ia64-devel] [PATCH 06/27] ia64/xen: define NET_SKB_NET to 18 if xen., Isaku Yamahata
- [Xen-ia64-devel] [PATCH 07/27] ia64/xen: define helper functions for xen related address conversion., Isaku Yamahata
- [Xen-ia64-devel] [PATCH 05/27] ia64/xen: define several constants for ia64/xen., Isaku Yamahata
- [Xen-ia64-devel] [PATCH 13/27] ia64/pv_ops/xen: elf note based xen startup., Isaku Yamahata
- [Xen-ia64-devel] [PATCH 09/27] ia64/xen: implement the arch specific part of xencomm., Isaku Yamahata
- [Xen-ia64-devel] [PATCH 08/27] ia64/xen: define helper functions for xen hypercalls., Isaku Yamahata
|
|
|
Home