This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-ia64-devel] [PATCH]Fix infinite loop in fault handler if debugg

To: SUZUKI Kazuhiro <kaz@xxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH]Fix infinite loop in fault handler if debugger is not connected
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Wed, 30 Jan 2008 11:49:27 -0700
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 30 Jan 2008 10:49:37 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080130.184009.180848202.kaz@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <20080123.173905.61770464.kaz@xxxxxxxxxxxxxxxxxx> <1201534558.6783.3.camel@lappy> <20080130.184009.180848202.kaz@xxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2008-01-30 at 18:40 +0900, SUZUKI Kazuhiro wrote:
> Hi Alex,
> Thank you for your comment.
> vcpu_increment_iip() takes a pointer of struct vcpu and calculate regs
> from vcpu.
> If current->arch._thread.on_ustack == 1 then regs == vcpu_regs(current),
> otherwise regs is created in the stack. vcpu_regs(current) indicates
> guest's registers.
> So we cannot use vcpu_increment_iip() in this part.
> How about this patch. 

   Thanks, this looks better.  I made one minor change to make use of
the ia64_psr() macro instead of manually extracting cr_ipsr.  Thanks,


Alex Williamson                             HP Open Source & Linux Org.

Xen-ia64-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>