WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] shadow_op not checking copy_user() result

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] shadow_op not checking copy_user() result
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Sun, 30 Dec 2007 14:07:45 -0700
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 30 Dec 2007 13:07:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20071221035354.GM23778%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <20071220173359.GJ4208@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20071221035354.GM23778%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2007-12-21 at 12:53 +0900, Isaku Yamahata wrote:
> On Thu, Dec 20, 2007 at 05:33:59PM +0000, Samuel Thibault wrote:
> > In xen/arch/ia64/xen/dom0_ops.c, in the XEN_DOMCTL_shadow_op case,
> > shouldn't the result of copy_user() be checked against 0, and if not,
> > return -EFAULT?
> 
> Good catch.
> It's very helpfull because very few takes care of IA64 port.
> Please keep paying attention to Xen/ia64.

   Applied.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>