WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-ia64-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-ia64-devel] shadow_op not checking copy_user() result

from [Isaku Yamahata] [Permanent Link][Original]
To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-ia64-devel] shadow_op not checking copy_user() result
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Fri, 21 Dec 2007 12:53:54 +0900
Delivery-date: Thu, 20 Dec 2007 19:54:08 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20071220173359.GJ4208@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20071220173359.GJ4208@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i 
On Thu, Dec 20, 2007 at 05:33:59PM +0000, Samuel Thibault wrote:
> In xen/arch/ia64/xen/dom0_ops.c, in the XEN_DOMCTL_shadow_op case,
> shouldn't the result of copy_user() be checked against 0, and if not,
> return -EFAULT?

Good catch.
It's very helpfull because very few takes care of IA64 port.
Please keep paying attention to Xen/ia64.

-- 
yamahata

Attachment: 16654_7e85a4e784c8_fix_xen_domctl_shadow_op.patch
Description: Text Data

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-ia64-devel] [PATCH] sort out the XEN_IA64_OPTF_IDENT_MAP_REG[457] constants confusion., Isaku Yamahata
Next by Date:  Re: [Xen-ia64-devel] [patch 00/12] Kexec: EFI Mapping: Take IV, Akio Takebe
Previous by Thread:  [Xen-ia64-devel] shadow_op not checking copy_user() result, Samuel Thibault
Next by Thread:  Re: [Xen-ia64-devel] shadow_op not checking copy_user() result, Alex Williamson
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy