This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can notbesaved whe

To: "Alex Williamson" <alex.williamson@xxxxxx>
Subject: RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can notbesaved when guest execute "reboot" instruction
From: "Zhang, Xing Z" <xing.z.zhang@xxxxxxxxx>
Date: Thu, 28 Jun 2007 12:51:28 +0800
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 27 Jun 2007 21:49:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1183002817.6550.35.camel@lappy>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ace5N/YbOJSMtfZ1R5S4C5rS5BrdpQAB0DZQ
Thread-topic: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can notbesaved when guest execute "reboot" instruction
>   Why must the hook be implemented in xc_ia64_hvm_build.c?  It's
>definitely the obvious candidate, but we could also make it an
>architecture dependent static inline in something like vl.h, where the
>overloading occurs now.  The overloading is a nice trick, but a context
>dependent function like that seems prone to errors to me.  Thanks,
[Wing] You may misunderstand my means. Yes, we can implement a hook in
vl.h as an inline function. But the hook must call the function
xc_ia64_save_to_nvram() which implemented in xc_ia64_hvm_build.c. And
the hook is called by xc_domain_shutdown() which in xc_domain.c. So
xc_domain_shutdown() belongs to libxenctrl.so while
xc_ia64_save_tonvram() belongs to libxenguest.so.

A way is move all NVRAM related functions to libxenctrl.so 

Xen-ia64-devel mailing list