WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can not besaved wh

To: "Zhang, Xing Z" <xing.z.zhang@xxxxxxxxx>
Subject: RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can not besaved when guest execute "reboot" instruction
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Wed, 27 Jun 2007 23:53:37 -0400
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 27 Jun 2007 20:51:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <823A93EED437D048963A3697DB0E35DE646BF0@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <823A93EED437D048963A3697DB0E35DE646BF0@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2007-06-27 at 10:37 +0800, Zhang, Xing Z wrote:
> >> Alex, If you agree with this patch, could you check in it ASAP and
> >> push it into Xen-unstable tree? So that RH can pick this patch for
> >> RHEL5.1.
> >>
> >> Any comment is welcome. Thx.
> >
> >   Isn't this rather asymmetrical with our domain destroy hook?  Why
> >can't we do something similar here?  Overloading the function with a
> >#def is pretty ugly.  Thanks,
> [Zhang, Xing Z] 
> Thanks your comments. But seems xc_domain.c belongs to libxenctrl.so
> while xc_ia64_hvm_build.c belongs to libxenguest.so. Can the function in
> libxenctrl.so call a function which in libxenguest.so? I add a hook in
> xc_domain.c but compiler complaining at link time.

   Why must the hook be implemented in xc_ia64_hvm_build.c?  It's
definitely the obvious candidate, but we could also make it an
architecture dependent static inline in something like vl.h, where the
overloading occurs now.  The overloading is a nice trick, but a context
dependent function like that seems prone to errors to me.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel