[Xen-ia64-devel] [Q] about assign_domain_page_replace

[Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>]

Hi, all

Is the following patch right?

diff -r aee991c7723a xen/arch/ia64/xen/mm.c
--- a/xen/arch/ia64/xen/mm.c    Wed May 09 16:34:47 2007 +0100
+++ b/xen/arch/ia64/xen/mm.c    Wed Jun 06 05:41:15 2007 +0900
@@ -1121,7 +1121,7 @@ assign_domain_page_replace(struct domain
     if (pte_mem(old_pte)) {
         unsigned long old_mfn = pte_pfn(old_pte);
 
-        // mfn = old_mfn case can happen when domain maps a granted page
+        // mfn != old_mfn case can happen when domain maps a granted page
         // twice with the same pseudo physial address.
         // It's non sense, but allowed.
         // __gnttab_map_grant_ref()


If so, I have one more question.
When assign_domain_page_replace() is called from __dom0vp_add_physmap(),
there are a case of mfn != old_mfn.
Is that correct case or a bug?

At that time, old_mfn->count_info=0.
So if I destroy the domain, hypervisor panic like the below.

(XEN) Xen BUG at mm.c:233
(XEN) FIXME: implement ia64 dump_execution_state() 
(XEN) **************************************** 
(XEN) Panic on CPU 1: 
(XEN) Xen BUG at mm.c:233                      
(XEN) **************************************** 
(XEN)                                          
(XEN) Reboot in five seconds...

Best Regards,

Akio Takebe


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel