Hi, Yamahata-san.
Thank you for your comments.
> BTW your signed-off-by is missing.
Sorry. I forgot it.
And I attach the patch again.
Signed-off-by: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>
>> 2. The xenheap area (from xen_pstart to xenheap_phys_end) must exist
>> in node0 from its design?
>> (As far as I know, if xenheap is not in node0, the initialization
>> process of xenheap recursively needs xenheap memory)
>
> It seems so because of _heap0 and avail0.
> it would be easily worked around by alllocating _heap[n] and avail[n]
> by boot allocator.
>
I agree.
I just wondered if there aren't any systems where xenheap area
is not in node0, because I could not find such work around in
source codes.
Thanks,
Daisuke Nishimura.
diff -r 2b14a1f22eec xen/arch/ia64/linux-xen/setup.c
--- a/xen/arch/ia64/linux-xen/setup.c Fri May 25 09:43:21 2007 -0600
+++ b/xen/arch/ia64/linux-xen/setup.c Mon May 28 13:26:25 2007 +0900
@@ -506,13 +506,6 @@ setup_arch (char **cmdline_p)
if (early_console_setup(*cmdline_p) == 0)
mark_bsp_online();
-#ifdef XEN
-}
-
-void __init
-late_setup_arch (char **cmdline_p)
-{
-#endif
#ifdef CONFIG_ACPI_BOOT
/* Initialize the ACPI boot-time table parser */
acpi_table_init();
@@ -525,6 +518,13 @@ late_setup_arch (char **cmdline_p)
# endif
#endif /* CONFIG_APCI_BOOT */
+#ifdef XEN
+}
+
+void __init
+late_setup_arch (char **cmdline_p)
+{
+#endif
#ifndef XEN
find_memory();
#endif
diff -r 2b14a1f22eec xen/arch/ia64/xen/xensetup.c
--- a/xen/arch/ia64/xen/xensetup.c Fri May 25 09:43:21 2007 -0600
+++ b/xen/arch/ia64/xen/xensetup.c Mon May 28 13:26:25 2007 +0900
@@ -433,12 +433,12 @@ void __init start_kernel(void)
alloc_dom0();
- end_boot_allocator();
-
init_xenheap_pages(__pa(xen_heap_start), xenheap_phys_end);
printk("Xen heap: %luMB (%lukB)\n",
(xenheap_phys_end-__pa(xen_heap_start)) >> 20,
(xenheap_phys_end-__pa(xen_heap_start)) >> 10);
+
+ end_boot_allocator();
late_setup_arch(&cmdline);
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
|
Home