WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH]fix initialization order of buddy allocator

To: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH]fix initialization order of buddy allocator
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Mon, 28 May 2007 20:28:17 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 28 May 2007 04:26:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <465AB393.50903@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <465AB393.50903@xxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Mon, May 28, 2007 at 07:48:51PM +0900, Daisuke Nishimura wrote:

> Machines with multi NUMA nodes may panic on bootup.
> Attached patch(for C/S15145), in which I modified
> the initialization order of buddy allocator, fixes
> this problem.
> I tested booting dom0/domVTi and kernel-make on guests.
> Any comments and feedbacks would be appreciated.

Good catch!


> 2. The xenheap area (from xen_pstart to xenheap_phys_end) must exist
>   in node0 from its design?
>   (As far as I know, if xenheap is not in node0, the initialization
>   process of xenheap recursively needs xenheap memory)

It seems so because of _heap0 and avail0.
it would be easily worked around by alllocating _heap[n] and avail[n]
by boot allocator.

BTW your signed-off-by is missing.
-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel