WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel][PATCH]get guest os type

To: "Alex Williamson" <alex.williamson@xxxxxx>
Subject: RE: [Xen-ia64-devel][PATCH]get guest os type
From: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Date: Fri, 11 May 2007 10:17:23 +0800
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 10 May 2007 19:15:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1178833343.27751.38.camel@bling>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceTTCV4UAL8g3MLT/C9KC/0Bh6xegAJgRmQ
Thread-topic: [Xen-ia64-devel][PATCH]get guest os type
The revised one per your comments

>   Any chance Intel could also implement the GFW hooks for this in
>http://xenbits.xensource.com/ext/efi-vfirmware.hg?
>

We'll look at this. 

Thanks,
Anthony


>-----Original Message-----
>From: Alex Williamson [mailto:alex.williamson@xxxxxx]
>Sent: 2007年5月11日 5:42
>To: Xu, Anthony
>Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-ia64-devel][PATCH]get guest os type
>
>Hi Anthony,
>
>   Cool, I'm glad this works.  Couple minor comments...
>
>On Wed, 2007-05-09 at 17:11 +0800, Xu, Anthony wrote:
>> diff -r eabda101b0c5 xen/arch/ia64/vmx/mmio.c
>> --- a/xen/arch/ia64/vmx/mmio.c  Tue May 08 13:12:52 2007 -0600
>> +++ b/xen/arch/ia64/vmx/mmio.c  Wed May 09 16:10:28 2007 +0800
>> @@ -188,6 +188,13 @@ int vmx_ide_pio_intercept(ioreq_t *p, u6
>>
>>  #define TO_LEGACY_IO(pa)  (((pa)>>12<<2)|((pa)&0x3))
>>
>> +static inline void set_os_type(VCPU *v, u64 type)
>> +{
>> +    if(type>OS_BASE && type<OS_END)
>> +        v->domain->arch.vmx_platform.gos_type = type;
>> +}
>
>   I think a gdprintk at some level that won't typically get printed
>would be appropriate here.
>
>> @@ -210,7 +217,9 @@ static void legacy_io_access(VCPU *vcpu,
>>      p->df = 0;
>>
>>      p->io_count++;
>> -
>> +
>> +    if(dir==IOREQ_WRITE && p->addr==OS_TYPE_PORT)
>> +        set_os_type(v, *val);
>
>   Should we 'return' here?
>
>   Any chance Intel could also implement the GFW hooks for this in
>http://xenbits.xensource.com/ext/efi-vfirmware.hg?
>
>Thanks,
>
>       Alex
>
>--
>Alex Williamson                             HP Open Source & Linux Org.

Attachment: guest_os_type2.patch
Description: guest_os_type2.patch

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
<Prev in Thread] Current Thread [Next in Thread>