Re: [Xen-ia64-devel][PATCH]get guest os type

[Alex Williamson <alex.williamson@xxxxxx>]

Hi Anthony,

   Cool, I'm glad this works.  Couple minor comments...

On Wed, 2007-05-09 at 17:11 +0800, Xu, Anthony wrote:
> diff -r eabda101b0c5 xen/arch/ia64/vmx/mmio.c
> --- a/xen/arch/ia64/vmx/mmio.c  Tue May 08 13:12:52 2007 -0600
> +++ b/xen/arch/ia64/vmx/mmio.c  Wed May 09 16:10:28 2007 +0800
> @@ -188,6 +188,13 @@ int vmx_ide_pio_intercept(ioreq_t *p, u6
>  
>  #define TO_LEGACY_IO(pa)  (((pa)>>12<<2)|((pa)&0x3))
>  
> +static inline void set_os_type(VCPU *v, u64 type)
> +{
> +    if(type>OS_BASE && type<OS_END)
> +        v->domain->arch.vmx_platform.gos_type = type; 
> +}

   I think a gdprintk at some level that won't typically get printed
would be appropriate here.

> @@ -210,7 +217,9 @@ static void legacy_io_access(VCPU *vcpu,
>      p->df = 0;
>  
>      p->io_count++;
> -
> +    
> +    if(dir==IOREQ_WRITE && p->addr==OS_TYPE_PORT)
> +        set_os_type(v, *val);

   Should we 'return' here?

   Any chance Intel could also implement the GFW hooks for this in
http://xenbits.xensource.com/ext/efi-vfirmware.hg?

Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel