Re: [Xen-ia64-devel] [PATCH] Port of mini-os to ia64

[Alex Williamson <alex.williamson@xxxxxx>]

On Wed, 2007-02-14 at 13:05 +0100, Dietmar Hahn wrote:
> Hi Alex,
> 
> >   Ok, sounds reasonable, thanks for the explanation.  I'd appreciate if
> > you'd make another pass through the patch to clean up white space
> > differences (I noticed some tab indenting mixed with space indenting),
> > line wrapping (80 column please), and maybe think about cleaning up some
> > of the bootverbose code with an inline.  I haven't looked at
> What do you mean with an inline?

   A static inline or perhaps a #define that hides the bootverbose
check.  It just seemed like it might clean up some of the "if
(bootverbose) printk(...)" messiness.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel