Re: [Xen-ia64-devel] [PATCH] Fix a bug in xencomm_copy_from/to_guest()

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Wed, Jan 03, 2007 at 08:08:43PM -0700, Alex Williamson wrote:

>    Could one or both of you please send a sign-off for the patch below
> if we agree this is the way to go?  Thanks,

Assuming Kazuhiro aggrees with my patch
Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>



>  
> > > --- xen/arch/ia64/xen/xencomm.c   2006-12-21 12:05:05.000000000 +0900
> > > +++ xen/arch/ia64/xen/xencomm.c.new       2006-12-27 19:12:19.000000000 
> > > +0900
> > > @@ -153,7 +153,7 @@ xencomm_copy_from_guest(
> > >          chunksz -= chunk_skip;
> > >          skip -= chunk_skip;
> > >  
> > > -        if (skip == 0) {
> > > +        if (skip == 0 && chunksz > 0) {
> > >              unsigned int bytes = min(chunksz, n - to_pos);
> > >             int res;
> > >  
> > > @@ -295,7 +295,7 @@ xencomm_copy_to_guest(
> > >          skip -= chunk_skip;
> > >          dest_paddr += chunk_skip;
> > >  
> > > -        if (skip == 0) {
> > > +        if (skip == 0 && chunksz > 0) {
> > >              unsigned int bytes = min(chunksz, n - from_pos);
> > >              int res;
> 
> -- 
> Alex Williamson                             HP Open Source & Linux Org.
> 
> 
> _______________________________________________
> Xen-ia64-devel mailing list
> Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ia64-devel
> 

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel