WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] Fix a bug in xencomm_copy_from/to_guest()

On Thu, 2006-12-28 at 15:53 +0900, SUZUKI Kazuhiro wrote:
> Hi Isaku,
> 
> Thank you for your comment.
> It seems good. I think that your patch is better.

   Could one or both of you please send a sign-off for the patch below
if we agree this is the way to go?  Thanks,

        Alex
 
> > --- xen/arch/ia64/xen/xencomm.c   2006-12-21 12:05:05.000000000 +0900
> > +++ xen/arch/ia64/xen/xencomm.c.new       2006-12-27 19:12:19.000000000 
> > +0900
> > @@ -153,7 +153,7 @@ xencomm_copy_from_guest(
> >          chunksz -= chunk_skip;
> >          skip -= chunk_skip;
> >  
> > -        if (skip == 0) {
> > +        if (skip == 0 && chunksz > 0) {
> >              unsigned int bytes = min(chunksz, n - to_pos);
> >             int res;
> >  
> > @@ -295,7 +295,7 @@ xencomm_copy_to_guest(
> >          skip -= chunk_skip;
> >          dest_paddr += chunk_skip;
> >  
> > -        if (skip == 0) {
> > +        if (skip == 0 && chunksz > 0) {
> >              unsigned int bytes = min(chunksz, n - from_pos);
> >              int res;

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>