WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] Cleanup for PV-on-HVM for IPF

To: DOI Tsunehisa <Doi.Tsunehisa@xxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] Cleanup for PV-on-HVM for IPF
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Mon, 04 Sep 2006 14:37:22 -0600
Cc: xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 04 Sep 2006 13:37:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44FBDC83.2070602@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <44FBDC83.2070602@xxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

   A couple comments below...

On Mon, 2006-09-04 at 16:57 +0900, DOI Tsunehisa wrote: 
>  #include <xen/interface/memory.h>
> +#ifdef CONFIG_VMX_GUEST
> +# define ia64_xenmem_reservation_op(op, xmr) (0)
> +#else /* CONFIG_VMX_GUEST */
>  int ia64_xenmem_reservation_op(unsigned long op,
>                  struct xen_memory_reservation* reservation__);
> +#endif /* CONFIG_XEN_HVM_GUEST */

   Typo, CONFIG_XEN_HVM_GUEST?  Personally I'd leave out the comment
next to the #else and #endif for such a short block of code.


>  #define pfn_to_mfn_for_dma(pfn) (pfn)
> @@ -67,6 +69,8 @@ mfn_to_local_pfn(unsigned long mfn)
>  #define phys_to_machine_for_dma(phys) (phys)
>  #define machine_to_phys_for_dma(machine) (machine)
>  #define mfn_to_local_pfn(mfn) (mfn)
> +
> +extern void xen_machphys_update(unsigned long mfn, unsigned long pfn);

   Isn't this going to be bad for the !CONFIG_XEN && !CONFIG_VMX_GUEST
case?  I think we still want the old empty definition then.  Thanks,

        Alex


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel