Re: [Xen-ia64-devel] [PATCH] Enable hash vtlb

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Vendredi 07 Avril 2006 13:41, Xu, Anthony a écrit :
> This patch is to enable hash vtlb on para domains.
Hi,

a few formal points:

You'd better to split your patch, because it has 3 parts: xm builder, warnings 
fix and hash vtlb.

I'd prefer not to have vmx_ calls from vcpu.c and others.  I think it is 
clearer to only vmx_* only for vti.

My only concern for performance is SMP-g: if we have to add locks, 
performances will decrease.  (You may reply this is my job :-)

And a question:
Does this patch fixes the gcc segfault bug ?  (if yes this is very good, if no 
this means the bug may not be in this area).

Tristan.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel