RE: [Xen-ia64-devel] [PATCH] implemented vcpu_ptc_l()

["Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>]

> From: Isaku Yamahata [mailto:yamahata@xxxxxxxxxxxxx] 
> Sent: Tuesday, December 06, 2005 12:18 AM
> To: Magenheimer, Dan (HP Labs Fort Collins)
> Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-ia64-devel] [PATCH] implemented vcpu_ptc_l()
> 
> Hi Dan-san.
> 
> On Mon, Dec 05, 2005 at 08:37:11PM -0800, Magenheimer, Dan 
> (HP Labs Fort Collins) wrote:
> > I think it is necessary to also purge the VHPT.
> 
> I think vhpt_flush_address() does it.
> Or do you mean that vhpt_flush_address() isn't enough or
> page size of VHPT entry assumption shouldn't be made?

No, your code is correct.  I'm sorry I didn't review the patch
carefully enough.

However, one other possible problem:  Around the call to
ia64_local_tlb_purge, I think you need to check if rr0
needs to be swapped (see similar code in vcpu_itc_i()).

Dan

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel