WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel] [PATCH] implemented vcpu_ptc_l()

To: "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject: RE: [Xen-ia64-devel] [PATCH] implemented vcpu_ptc_l()
From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
Date: Tue, 6 Dec 2005 08:16:13 -0800
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 06 Dec 2005 16:16:28 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcX6NTk8/0PPaetnTRqqor/suyiBaAASltaQ
Thread-topic: [Xen-ia64-devel] [PATCH] implemented vcpu_ptc_l()
> From: Isaku Yamahata [mailto:yamahata@xxxxxxxxxxxxx] 
> Sent: Tuesday, December 06, 2005 12:18 AM
> To: Magenheimer, Dan (HP Labs Fort Collins)
> Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-ia64-devel] [PATCH] implemented vcpu_ptc_l()
> 
> Hi Dan-san.
> 
> On Mon, Dec 05, 2005 at 08:37:11PM -0800, Magenheimer, Dan 
> (HP Labs Fort Collins) wrote:
> > I think it is necessary to also purge the VHPT.
> 
> I think vhpt_flush_address() does it.
> Or do you mean that vhpt_flush_address() isn't enough or
> page size of VHPT entry assumption shouldn't be made?

No, your code is correct.  I'm sorry I didn't review the patch
carefully enough.

However, one other possible problem:  Around the call to
ia64_local_tlb_purge, I think you need to check if rr0
needs to be swapped (see similar code in vcpu_itc_i()).

Dan

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel