This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-ia64-devel] RE: Patches for ia64 arch_vcpu_info_t merge

To: "Magenheimer, Dan \(HP Labs Fort Collins\)" <dan.magenheimer@xxxxxx>, "Yang, Fred" <fred.yang@xxxxxxxxx>
Subject: RE: [Xen-ia64-devel] RE: Patches for ia64 arch_vcpu_info_t merge
From: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Date: Thu, 21 Jul 2005 02:52:55 +0800
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 20 Jul 2005 18:51:47 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: DIscussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcWNBPP5QiQvfRGuScu1N9oRQYcAEwAUEdtQAAEZ5GA=
Thread-topic: [Xen-ia64-devel] RE: Patches for ia64 arch_vcpu_info_t merge
Magenheimer, Dan (HP Labs Fort Collins) wrote:
> Is there a reason that the passing of the shared memory pointer
> in r31 has been disabled by the patch?  It isn't used much right now
> but I intend to use it more in the future.
        Yes, no strong reason and only for simpilification as
&((shared_info_t *)SHAREDINFO_ADDR)->vcpu_data[0].arch is not point to
ipsr and ipsr is not 1st address of shared_archinfo now. I will let it
there. But the key thing now is that I don't know why the patch fail in
your previous test tree, can u have a try base on the latest patch and
let us know much detail failure message so that Kevin can debug early in
case the problem is still there.
        I guess the problem will not be there :-)

        Can you try following manual patch and send dan new patch?

diff -r ea8caf38c914 xen/arch/ia64/process.c
--- a/xen/arch/ia64/process.c   Wed Jul 13 20:18:04 2005
+++ b/xen/arch/ia64/process.c   Thu Jul 14 14:42:21 2005
@@ -226,7 +226,7 @@
 #ifdef CONFIG_SMP
 #error "sharedinfo doesn't handle smp yet"
-       regs->r31 = &((shared_info_t
+       regs->r31 = &((arch_vcpu_info_t *)SHARED_ARCHINFO_ADDR)->ipsr);
        PSCB(v,interrupt_delivery_enabled) = 0;
        PSCB(v,interrupt_collection_enabled) = 0; 

And following patch is not necessary now:
diff -r 5fcf5a856e25 arch/ia64/xen/xenivt.S
--- a/arch/ia64/xen/xenivt.S    Wed Jul 13 22:37:53 2005
+++ b/arch/ia64/xen/xenivt.S    Thu Jul 14 14:34:31 2005
@@ -407,6 +407,8 @@
 #ifdef CONFIG_XEN
+        movl r31=XSI_IPSR
+       ;;
        ld8 r21=[r31],XSI_IFA-XSI_IPSR  // get ipsr, point to ifa
        movl r17=PAGE_KERNEL
@@ -471,6 +473,8 @@
 #ifdef CONFIG_XEN
+        movl r31=XSI_IPSR
+       ;;
        ld8 r21=[r31],XSI_ISR-XSI_IPSR  // get ipsr, point to isr
        movl r17=PAGE_KERNEL
@@ -964,6 +969,8 @@
 #ifdef CONFIG_XEN
+        movl r31=XSI_IPSR
+       ;;
        ld8 r29=[r31],XSI_IIP-XSI_IPSR          // get ipsr, point to
        mov r18=__IA64_BREAK_SYSCALL
        mov r21=ar.fpsr

Xen-ia64-devel mailing list