WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture

from [ANNIE LI] [Permanent Link][Original]
To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture
From: ANNIE LI <annie.li@xxxxxxxxxx>
Date: Thu, 10 Nov 2011 09:56:56 +0800
Cc: "jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, "kurt.hackel@xxxxxxxxxx" <kurt.hackel@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Paul Durrant <Paul.Durrant@xxxxxxxxxx>
Delivery-date: Wed, 09 Nov 2011 17:59:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1320855724.955.183.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Oracle Corporation
References: <4EBA35D3.3020506@xxxxxxxxxx> <1320826490-29362-1-git-send-email-annie.li@xxxxxxxxxx> <291EDFCB1E9E224A99088639C4762022B4543AB1BD@xxxxxxxxxxxxxxxxxxxxxxxxx> <20111109144922.GC8410@xxxxxxxxxxxxxxxxxxx> <291EDFCB1E9E224A99088639C4762022B4543AB204@xxxxxxxxxxxxxxxxxxxxxxxxx> <4EBAA3B1.8010401@xxxxxxxxxx> <1320855724.955.183.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.23) Gecko/20110920 Thunderbird/3.1.15 


On 2011-11-10 0:22, Ian Campbell wrote:

IMHO the gnttab_ bit belongs in either (or both) the struct name or the
variable names referencing the struct, rather than the fields
themselves. It should be obvious from the context that this member is
something to do with gnttab. e.g. I think gnttab_shared->addr would be
fine, as would shared->addr in the context of gnttab.c etc.

Right.
Thanks you all for the review, I will improve patches based on those suggestions and resend them. 

Thanks
Annie

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture, ANNIE LI
Next by Date:  [Xen-devel] Question about unplug a pass-through device, NaizhengTAN
Previous by Thread:  Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture, Ian Campbell
Next by Thread:  [Xen-devel] Re: [PATCH 1/3] Introducing grant table V2 stucture, annie li
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy