|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture
To: |
annie li <annie.li@xxxxxxxxxx> |
Subject: |
Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture |
From: |
Ian Campbell <Ian.Campbell@xxxxxxxxxx> |
Date: |
Wed, 9 Nov 2011 16:22:04 +0000 |
Cc: |
"jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, "kurt.hackel@xxxxxxxxxx" <kurt.hackel@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Paul Durrant <Paul.Durrant@xxxxxxxxxx> |
Delivery-date: |
Wed, 09 Nov 2011 08:30:50 -0800 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<4EBAA3B1.8010401@xxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
Organization: |
Citrix Systems, Inc. |
References: |
<4EBA35D3.3020506@xxxxxxxxxx> <1320826490-29362-1-git-send-email-annie.li@xxxxxxxxxx> <291EDFCB1E9E224A99088639C4762022B4543AB1BD@xxxxxxxxxxxxxxxxxxxxxxxxx> <20111109144922.GC8410@xxxxxxxxxxxxxxxxxxx> <291EDFCB1E9E224A99088639C4762022B4543AB204@xxxxxxxxxxxxxxxxxxxxxxxxx> <4EBAA3B1.8010401@xxxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Wed, 2011-11-09 at 16:00 +0000, annie li wrote:
> Maybe addr or gnttab_addr?
IMHO the gnttab_ bit belongs in either (or both) the struct name or the
variable names referencing the struct, rather than the fields
themselves. It should be obvious from the context that this member is
something to do with gnttab. e.g. I think gnttab_shared->addr would be
fine, as would shared->addr in the context of gnttab.c etc.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|