WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] IRQ: move a few more bits into common code

To: Jan Beulich <JBeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] IRQ: move a few more bits into common code
From: Keir Fraser <keir@xxxxxxx>
Date: Mon, 07 Nov 2011 14:33:41 +0000
Cc:
Delivery-date: Mon, 07 Nov 2011 06:34:39 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=c/eTnHorGRE8T5e9a3f4pFBhyr8MqY78j0oj9ssFIHg=; b=L+KR/z8GLIElPtipRCnVWnuwKduWVpWBwv6SFRgLFRcnMYasklb+X/hp9zDnhp+N0r ph57yfJkZDGI5WUlt9251Hc6hKceg/ByyCc3ENOqScfaWTxHORPm85KqGnkECcSY5mac KzUnUXMeV3Ox3FHlLKoVnr8n/fZUFokXvFYN8=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4EB7BA9B020000780005F4CD@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcydWj6dYWodmaBeLEC239IMPs03jw==
Thread-topic: [Xen-devel] [PATCH] IRQ: move a few more bits into common code
User-agent: Microsoft-Entourage/12.30.0.110427
On 07/11/2011 10:01, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> ... as they're not really arch-specific.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Keir Fraser <keir@xxxxxxx>

> --- a/xen/arch/ia64/xen/irq.c
> +++ b/xen/arch/ia64/xen/irq.c
> @@ -105,15 +105,6 @@ void __do_IRQ_guest(int irq);
>   * Special irq handlers.
>   */
>  
> -void no_action(int cpl, void *dev_id, struct pt_regs *regs) { }
> -
> -/*
> - * Generic no controller code
> - */
> -
> -static void enable_none(unsigned int irq) { }
> -static unsigned int startup_none(unsigned int irq) { return 0; }
> -static void disable_none(unsigned int irq) { }
>  static void ack_none(unsigned int irq)
>  {
>  /*
> @@ -124,18 +115,14 @@ static void ack_none(unsigned int irq)
> printk(KERN_ERR "Unexpected irq vector 0x%x on CPU %u!\n", irq,
> smp_processor_id());
>  }
>  
> -/* startup is the same as "enable", shutdown is same as "disable" */
> -#define shutdown_none disable_none
> -#define end_none enable_none
> -
>  hw_irq_controller no_irq_type = {
> - "none",
> - startup_none,
> - shutdown_none,
> - enable_none,
> - disable_none,
> - ack_none,
> - end_none
> + .typename = "none",
> + .startup = irq_startup_none,
> + .shutdown = irq_shutdown_none,
> + .enable = irq_enable_none,
> + .disable = irq_disable_none,
> + .ack = ack_none,
> + .end = irq_actor_none
>  };
>  
>  /*
> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -356,10 +356,6 @@ int __init init_irq_data(void)
>  
>  static void __do_IRQ_guest(int vector);
>  
> -void no_action(int cpl, void *dev_id, struct cpu_user_regs *regs) { }
> -
> -void irq_actor_none(struct irq_desc *desc) { }
> -unsigned int irq_startup_none(struct irq_desc *desc) { return 0; }
>  static void ack_none(struct irq_desc *desc)
>  {
>      ack_bad_irq(desc->irq);
> --- a/xen/common/irq.c
> +++ b/xen/common/irq.c
> @@ -26,3 +26,16 @@ int init_one_irq_desc(struct irq_desc *d
>  
>      return err;
>  }
> +
> +void no_action(int cpl, void *dev_id, struct cpu_user_regs *regs)
> +{
> +}
> +
> +void irq_actor_none(struct irq_desc *desc)
> +{
> +}
> +
> +unsigned int irq_startup_none(struct irq_desc *desc)
> +{
> +    return 0;
> +}
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>