WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xen: provide pse36 cpuid bit

To: Christoph Egger <Christoph.Egger@xxxxxxx>, Tim Deegan <tim@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: provide pse36 cpuid bit
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Thu, 27 Oct 2011 15:59:45 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 27 Oct 2011 08:07:37 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=DrE4R/GotDoZjQXWW932oi8x9Xeqa5IOmLOLKHQ4j/I=; b=vRpTrnYRxwtqq3TUmIlSLqlCUmXoIWLbB68gsxvrWZEfmnAGJ0hWx+CQ0UxhPtgKTN AHDEuDVQLY0p+OYjaH4D4Vw/plx8PqQS3UHeXsf9ZWJf9a5lVbO7FvpSo9/ydh6/JGF2 AQb+fNEDvusqXU7wabtaY7LiZf6S8mJo+nBLQ=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4EA96B0F.4070607@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcyUuRBJcVlURk1PvkKhP/tpyrx99g==
Thread-topic: [Xen-devel] [PATCH] xen: provide pse36 cpuid bit
User-agent: Microsoft-Entourage/12.30.0.110427
On 27/10/2011 15:30, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> On 10/27/11 16:06, Tim Deegan wrote:
>> At 14:10 +0200 on 27 Oct (1319724631), Christoph Egger wrote:
>>> 
>>> Provide pse36 cpuid bit if guest runs in 32bit PAE
>>> or in long mode. Hyper-V refuses to start as
>>> the "cpu does not provide required hw features"
>>> if it does not find the pse36 cpuid bits.
>>> 
>>> Signed-off-by: Christoph Egger<Christoph.Egger@xxxxxxx>
>> 
>> This patch appears to advertise PSE36 support to guests without actually
>> supporting PSE36.  Or am I missing something?
> 
> That's right. The paging format differs only in 32bit legacy mode.
> Since Hyper-V is not running in 32bit legacy mode but insists on having
> these cpuid bits present it is sufficient to just populate them to the
> guest when guest paging mode != 32bit legacy mode.

It would be nice if we didn't have to toggle CPUID.PSE36 based on current
guest mode. How hard would it be to pull out bits 35..32 of a physical
address from bits 16..13 of a legacy 32-bit PDE whose PS flag = 1?

I'm actually surprised we don't do it already, it's so trivial! The code
explicitly says we don't though, and for a reason that makes no sense to
me...

 -- Keir

> Christoph
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel