Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries at the end of the compile flags

[Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>]

2011/10/17 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> Roger Pau Monné writes ("Re: [Xen-devel] [PATCH] tools/build: append user 
> includes and libraries at the end of the compile flags"):
>> In .config extra libraries and includes should be defined with
>> EXTRA_INCLUDES and EXTRA_LIB (the same way it is now), USER_LDFLAGS
>> and USER_CFLAGS is an internal make variable, and should not be set
>> directly by the user. Notice the lines:
>>
>> +USER_LDFLAGS += $(foreach i, $(EXTRA_LIB), -L$(i))
>> +USER_CFLAGS += $(foreach i, $(EXTRA_INCLUDES), -I$(i))
>>
>> EXTRA_LIB and EXTRA_INCLUDES is added to USER_LDFLAGS and USER_CFLAGS
>> instead of LDFLAGS and CFLAGS.
>
> Oh, sorry, I didn't spot that.
>
> In that case I think it's not correct because that's changing the
> semantics of the existing EXTRA_* variables.  In particular, some
> people might currently set EXTRA_* expecting them to come first.
>
> We should have a new variable for the new semantics.  I confess I
> didn't read your patch closely enough to spot that you hadn't done
> that...

Ok, in that case I think we should define a new variable called
USER_CFLAGS and USER_LDFLAGS if everyone is comfortable with that. I
will send a new version with this changes.

>
> Ian.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel