 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries
| To: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries at the end of the compile flags |
| From: | Roger Pau Monné <roger.pau@xxxxxxxxxxxxx> |
| Date: | Mon, 17 Oct 2011 16:38:55 +0200 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Mon, 17 Oct 2011 07:39:27 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ZPsLPGa0L9t6UQQL26GziVZR3IpZDcUUeYv3Lt9nEQ0=; b=BR4BXYaT0PPd9EQG5shl68+cBoVm4ocXZlnOevVTDr27odeGvwMTQ9n+A8wcZMke1W GNyLpS9h2PWJpunCbyPRY6Ux9DwDWB3c8CMRHmXsKCWG1yuL2V1jIk4BAuaDWzJrA004 rc3gky2Q4B7haQIgixPH/dMAZJm2TkRl3HEmQ= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20124.15541.672787.681791@xxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <ae251a2f9490dfa98553.1318594610@loki> <20124.15541.672787.681791@xxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
> This looks reasonable to me, although the commit message still talks
> about EXTRA_*. Is everyone happy with the name
> USER_{LDFLAGS,CFLAGS} ?
In .config extra libraries and includes should be defined with
EXTRA_INCLUDES and EXTRA_LIB (the same way it is now), USER_LDFLAGS
and USER_CFLAGS is an internal make variable, and should not be set
directly by the user. Notice the lines:
+USER_LDFLAGS += $(foreach i, $(EXTRA_LIB), -L$(i))
+USER_CFLAGS += $(foreach i, $(EXTRA_INCLUDES), -I$(i))
EXTRA_LIB and EXTRA_INCLUDES is added to USER_LDFLAGS and USER_CFLAGS
instead of LDFLAGS and CFLAGS.
> I'll give people a few days to comment, but I'm inclined to apply this
> one.
>
> Thanks,
> Ian.
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| Previous by Date: | Re: [Xen-devel] [PATCH 18 of 27 v2] libxl: merge libxl__device_del into libxl__device_remove, Roger Pau Monné |
|---|---|
| Next by Date: | Re: [Xen-devel] how hypervisor separates assembly instructions, Ian Jackson |
| Previous by Thread: | Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries at the end of the compile flags, Ian Jackson |
| Next by Thread: | Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries at the end of the compile flags, Ian Jackson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
