WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: hvm_domain_use_pirq() breaks device passthru on xen-4.1

To: Wei Huang <wei.huang2@xxxxxxx>
Subject: [Xen-devel] Re: hvm_domain_use_pirq() breaks device passthru on xen-4.1
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Tue, 16 Aug 2011 19:15:49 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 16 Aug 2011 11:10:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E3AE881.5060806@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4E396C590200007800073F3D@xxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1108032156320.12963@kaball-desktop> <4E3AE881.5060806@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Thu, 4 Aug 2011, Wei Huang wrote:
> Hi Stefano,
> 
> The recent patch you put into xen-4.1-testing.hg broke device passthru 
> on Windows. I bisected the changesets and it turned out to be 23092. The 
> NIC can't get the IP address correctly. Changset 23091 worked fine.
> 
> Regarding your patch, do we need to differentiate pv-on-hvm guests from 
> others? The Windows VM I used is unmodified. I think 
> hvm_domain_use_pirq() returned an incorrect answer for such guests.

The problem is that when qemu enables MSIs for a pt device on behalf of
the guest physdev_map_pirq is called and pirq_emuirq is set to IRQ_PT.
>From that point on hvm_domain_use_pirq is going to return true
incorrectly.
Before 23092 we would also check for the event channel to be bound
before returning true in hvm_domain_use_pirq, but that turns out to be a
problem if a PV on HVM guest disables and unbinds the event channel.

I think that reverting 23092 is the simplest thing to do here, then we
need to find a different way to distinguish MSIs that have to be
injected using the emulated path and the ones that have to be injected
using the PV path.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>